Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ai video deprecate priceperbroadcaster #3061

Merged
merged 1 commit into from
May 20, 2024

Conversation

rickstaa
Copy link
Member

@rickstaa rickstaa commented May 20, 2024

What does this pull request do? Explain your changes. (required)

This pull request adds the pricePerGateway flag and deprecates the pricePerBroadcaster flag per core team decision (details: https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004). It adds the new -pricePerGateway flag while maintaining support for -pricePerBroadcaster with a deprecation warning on startup. This change does not address refactoring associated with variable names and types, which will be addressed in a later change.

Specific updates (required)

  • Updates starter.go and livepeer.go to include the -pricePerGateway flag
  • Updates the getBroadcasters function to parse the gateways property instead of the broadcasters property.
  • Adds deprecation warnings to startup and cli help
W0516 11:37:39.563931   97531 starter.go:785] -PricePerBroadcaster flag is deprecated and will be removed in a future release. Please use -PricePerGateway instead

How did you test each of these updates (required)

  • Started a on-chain orchestrator node using the -pricePerGateway flag
  • Started a on-chain orchestrator node using the -pricePerBroadcaster flag, noted deprecation warning
  • Started a on-chain orchestrator node while using the broadcasters property in the config specified in the -pricePerGateway flag, noted deprecation warning.

Does this pull request close any open issues?

AI-LIV-358

Checklist:

This commit adds the `pricePerGateway` flag and deprecates the
`pricePerBroadcaster` flag
per core team decision (details:
https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004).
@rickstaa rickstaa changed the base branch from master to ai-video May 20, 2024 10:59
@rickstaa rickstaa merged commit 35db3f2 into ai-video May 20, 2024
1 check passed
@rickstaa rickstaa deleted the ai-video_deprecate_priceperbroadcaster branch May 20, 2024 11:01
@rickstaa rickstaa mentioned this pull request Jun 10, 2024
5 tasks
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Jul 26, 2024
…vepeer#3061)

This commit adds the `pricePerGateway` flag and deprecates the
`pricePerBroadcaster` flag
per core team decision (details:
https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant