Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Fix bonding notification error #287

Merged
merged 1 commit into from
Dec 16, 2018
Merged

Fix bonding notification error #287

merged 1 commit into from
Dec 16, 2018

Conversation

adamsoffer
Copy link
Collaborator

What does this pull request do? Explain your changes. (required)
This PR fixes an issue on staging where a bonding notification error appears even in the case where a transaction is successfully confirmed. The issue was caused by a breaking change in graphql-js v14.0.0 where servers that used to accept incorrect variable values now return errors to clients.

Specific updates (required)

  • Updated the bond mutation so that it returns the correct custom scalar type (JSON as opposed to Boolean).
  • Regenerated the graphql-sdk README and docs

How did you test each of these updates (required)

  • Received a success notification after successfully bonding in the explorer
  • Received a success notification after successfully unbonding in the explorer
  • Received a success notifcation after successfully claiming rewards in the explorer
  • Reran graph-sdk tests

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Copy link
Contributor

@Randy1Burrell Randy1Burrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good.

@Randy1Burrell Randy1Burrell merged commit 029c99e into livepeer:master Dec 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants