Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-integer framerates #192

Merged
merged 2 commits into from
May 22, 2020
Merged

Support non-integer framerates #192

merged 2 commits into from
May 22, 2020

Conversation

jailuthra
Copy link
Contributor

Why?
These changes are for supporting non-integer FPS output in LPMS. See go-livepeer#1474 for details.

What?

  • Add a FramerateDen field in VideoProfile
  • Set the rational FPS in the FFmpeg filtergraph string & Cgo transcoder params
  • Add unit tests to verify that common fractional FPS cases work as expected

@jailuthra jailuthra requested review from j0sh and darkdarkdragon May 22, 2020 11:59
j0sh
j0sh approved these changes May 22, 2020
View reviewed changes
Copy link
Collaborator

@j0sh j0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. 🚢

@jailuthra jailuthra merged commit d7c5ccd into master May 22, 2020
@j0sh j0sh mentioned this pull request May 29, 2020
Merged
@jailuthra jailuthra deleted the jl/ratfps branch June 12, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0sh j0sh j0sh approved these changes

@darkdarkdragon darkdarkdragon Awaiting requested review from darkdarkdragon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jailuthra @j0sh