-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle zero-frame (audio-only) segments at the start of a session #204
Conversation
Right on — testing this now against the MistServer environment where we were encountering the problem. |
8bc28e3
to
b93e71b
Compare
Force-pushed the suggestions in review comments. |
A few team members have found fixup commits to be helpful for the review process for go-livepeer since reviewers can easily view the diff that addresses a set of requested changes (instead of viewing the entire file(s)) and the contributor can just auto-squash the fixup commits during a rebase before the merge. We also have a GitHub action in go-livepeer that blocks merges when fixup commits have not been squashed. Perhaps some of these things could be useful in this repo as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ah TIL, I had no idea about fixup/squashing in github, will use it from now thanks! |
Why?
For details check the audio-only bug this PR fixes #203
How?
We bypass the usual transcoding process for the first n-segments of a stream that do not have any frames, but do have a valid video substream present in the container format.
The bypassing is done by forcing the copy transcoder 8bc28e3 for such segments.
Testing Done: