decoder: Error out on segments with no keyframe packets #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jailuthra
force-pushed
the
jai/kryptonite
branch
from
21ebe47 to
406f8f9
Compare
jailuthra
changed the title
yondonfu
reviewed
Jan 21, 2021
3 tasks
jailuthra
force-pushed
the
jai/kryptonite
branch
from
7ea1c22 to
fb58611
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The video decoder currently gets stuck in an infinite loop while flushing if the input segment does not contain any keyframes, as it uses the first keyframe packet to flush the decoder buffer.
What?
If no keyframe packet is found after reading and sending all packets to the decoder, return an explicit error and don't try to flush.
Testing
Fixes
Fixes #219