Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated change transitions #26

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Animated change transitions #26

wants to merge 5 commits into from

Conversation

tyom
Copy link

@tyom tyom commented Jan 22, 2015

Initiated in #11. Rebased and improved.

@andreyvit
Copy link
Member

Thank you, that was very kind of you! I'm waiting for a bit of time to review it and make a few changes, but basically we're good to go here.

I'll also add a comment or two inline now.

README.md Outdated
@@ -120,6 +120,10 @@ Alternatively, instead of loading livereload.js from the LiveReload server, you
<script src="https://github.com/livereload/livereload-js/raw/master/dist/livereload.js?host=localhost"></script>
```

### Animated transitions

LiveReload can animate changes. To enable animated transitions pass `animate=true` to `livereload.js` when including in the script tag. The default transition duration is 280ms and is configurable via `animation_duration`. The value is integer in milliseconds.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to allow e.g. animate=200, animate=400 in addition to animate=true to optionally specify the duration?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. I'll update.

@tyom
Copy link
Author

tyom commented Jan 24, 2015

@andreyvit: Updated. Please review.

@AlecRust
Copy link

AlecRust commented May 4, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants