Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Monitor Configuration #6

Closed
airgradienthq opened this issue Oct 9, 2023 · 3 comments
Closed

Multi Monitor Configuration #6

airgradienthq opened this issue Oct 9, 2023 · 3 comments

Comments

@airgradienthq
Copy link

Achim from AirGradient here. Many thanks for building this.

I have one suggestion. Many people have several monitors on their dashboard and it would be great to add the possibility to define which monitor would be shown.

In our API we have the locationID for this:
https://api.airgradient.com/public/docs/api/v1/#/default/getCurrentMeasures

and the locationID can be seen on our dashboard:
https://app.airgradient.com/settings/location

@ljagiello
Copy link
Owner

Hey @airgradienthq ,

That's a great idea, so far I have only single monitor, but I can absolutely see this being helpful. I will update this issue once I have something working.

@airgradienthq
Copy link
Author

airgradienthq commented Oct 10, 2023

I have 20 monitors running on my place so it would be really great if that could be implemented

ljagiello added a commit that referenced this issue Oct 11, 2023
## Issue:
* #6

## Changes
* Added support to select monitor location
* Dedicated function for converting temperature
* Added additional test cases
* Rename test cases with better names
@ljagiello
Copy link
Owner

Hey @airgradienthq

I have added support for locationId. Now airdash should support configuration with or without locationId.

If locationId is defined in the configuration, the app will fetch measurements from the selected location. If locationId is not defined in the configuration (or uses the default value of 0), the app will use the previous API path with all locations and select the first one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants