Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-7: json: cannot unmarshal number #8

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Issue-7: json: cannot unmarshal number #8

merged 3 commits into from
Oct 10, 2023

Conversation

ljagiello
Copy link
Owner

@ljagiello ljagiello commented Oct 9, 2023 •
edited
Loading

Issue:

Changes

  • Replace int with float64
  • Replace sweat drop emoji with droplet emoji
  • Update screenshot
  • Move fetch/unmarshal to dedicated function
  • Add tests for Unmarshal API payloads

TODO

  • Add test cases for different payloads

@ljagiello
Issue-7: json: cannot unmarshal number
51a9ba7 
* Replace int with float64
* Replace sweat drop emoji with droplet emoji
* Update screenshot
@ljagiello
Move fetch/unmarshal to dedicated function
7b913a6
@ljagiello
Add tests for Unmarshal API payloads
195933e
@ljagiello ljagiello marked this pull request as ready for review October 10, 2023 05:25
@ljagiello ljagiello merged commit 4573904 into main Oct 10, 2023
1 check passed
@ljagiello ljagiello deleted the airdash-issue-7 branch October 10, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ljagiello