[Robustness] ES2017+: NumberToRawBytes, NumericToRawBytes: use …

…`SameValue` instead of `Object.is`
ljharb · Jun 7, 2023 · b2c2e6c · b2c2e6c
1 parent a36004f
commit b2c2e6c
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 6 deletions.
diff --git a/2017/NumberToRawBytes.js b/2017/NumberToRawBytes.js
@@ -20,6 +20,7 @@ var $strSlice = callBound('String.prototype.slice');
 
 var abs = require('./abs');
 var hasOwnProperty = require('./HasOwnProperty');
+var SameValue = require('./SameValue');
 var ToInt16 = require('./ToInt16');
 var ToInt32 = require('./ToInt32');
 var ToInt8 = require('./ToInt8');
@@ -83,7 +84,7 @@ module.exports = function NumberToRawBytes(type, value, isLittleEndian) {
 		var leastSig;
 
 		if (value === 0) {
-			leastSig = Object.is(value, -0) ? 0x80 : 0;
+			leastSig = SameValue(value, -0) ? 0x80 : 0;
 			return isLittleEndian ? [0, 0, 0, leastSig] : [leastSig, 0, 0, 0];
 		}
 

diff --git a/2018/NumberToRawBytes.js b/2018/NumberToRawBytes.js
diff --git a/2019/NumberToRawBytes.js b/2019/NumberToRawBytes.js
diff --git a/2020/NumericToRawBytes.js b/2020/NumericToRawBytes.js
@@ -22,6 +22,7 @@ var $strSlice = callBound('String.prototype.slice');
 
 var abs = require('./abs');
 var hasOwnProperty = require('./HasOwnProperty');
+var SameValue = require('./SameValue');
 var ToBigInt64 = require('./ToBigInt64');
 var ToBigUint64 = require('./ToBigUint64');
 var ToInt16 = require('./ToInt16');
@@ -91,7 +92,7 @@ module.exports = function NumericToRawBytes(type, value, isLittleEndian) {
 		var leastSig;
 
 		if (value === 0) {
-			leastSig = Object.is(value, -0) ? 0x80 : 0;
+			leastSig = SameValue(value, -0) ? 0x80 : 0;
 			return isLittleEndian ? [0, 0, 0, leastSig] : [leastSig, 0, 0, 0];
 		}
 

diff --git a/2021/NumericToRawBytes.js b/2021/NumericToRawBytes.js
diff --git a/2022/NumericToRawBytes.js b/2022/NumericToRawBytes.js