Skip to content

Commit

Permalink
[Fix] no-unused-modules: avoid a crash when processing re-exports
Browse files Browse the repository at this point in the history
  • Loading branch information
ljharb committed Mar 13, 2022
1 parent 747d6dc commit 2352c1f
Show file tree
Hide file tree
Showing 7 changed files with 33 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
- [`default`]: `typescript-eslint-parser`: avoid a crash on exporting as namespace (thanks [@ljharb])
- [`export`]/TypeScript: false positive for typescript namespace merging ([#1964], thanks [@magarcia])
- [`no-duplicates`]: ignore duplicate modules in different TypeScript module declarations ([#2378], thanks [@remcohaszing])
- [`no-unused-modules`]: avoid a crash when processing re-exports ([#2388], thanks [@ljharb])

### Changed
- [Tests] `no-nodejs-modules`: add tests for node protocol URL ([#2367], thanks [@sosukesuzuki])
Expand Down Expand Up @@ -973,6 +974,7 @@ for info on changes for earlier releases.
[`memo-parser`]: ./memo-parser/README.md

[#2393]: https://github.com/import-js/eslint-plugin-import/pull/2393
[#2388]: https://github.com/import-js/eslint-plugin-import/pull/2388
[#2381]: https://github.com/import-js/eslint-plugin-import/pull/2381
[#2378]: https://github.com/import-js/eslint-plugin-import/pull/2378
[#2371]: https://github.com/import-js/eslint-plugin-import/pull/2371
Expand Down
6 changes: 4 additions & 2 deletions src/rules/no-unused-modules.js
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,10 @@ const prepareImportsAndExports = (srcFiles, context) => {
exportAll.forEach((value, key) => {
value.forEach(val => {
const currentExports = exportList.get(val);
const currentExport = currentExports.get(EXPORT_ALL_DECLARATION);
currentExport.whereUsed.add(key);
if (currentExports) {
const currentExport = currentExports.get(EXPORT_ALL_DECLARATION);
currentExport.whereUsed.add(key);
}
});
});
};
Expand Down
5 changes: 5 additions & 0 deletions tests/files/unused-modules-reexport-crash/src/App.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { hello } from './magic/test'

hello();

export default function App() {};
3 changes: 3 additions & 0 deletions tests/files/unused-modules-reexport-crash/src/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import App from './App';

export const x = App
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './test'
7 changes: 7 additions & 0 deletions tests/files/unused-modules-reexport-crash/src/magic/test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export function hello() {
console.log('hello!!');
}

export function unused() {
console.log('im unused!!');
}
11 changes: 11 additions & 0 deletions tests/src/rules/no-unused-modules.js
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,17 @@ ruleTester.run('no-unused-modules', rule, {
filename: testFilePath('./no-unused-modules/file-o.js'),
parser: parsers.BABEL_OLD,
}),
test({
code: `
import App from './App';
`,
filename: testFilePath('./unused-modules-reexport-crash/src/index.tsx'),
parser: parsers.TS_NEW,
options: [{
unusedExports: true,
ignoreExports: ['**/magic/**'],
}],
}),
],
invalid: [
test({
Expand Down

0 comments on commit 2352c1f

Please sign in to comment.