Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub actions PR #8

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

GitHub actions PR #8

wants to merge 6 commits into from

Conversation

sladyn98
Copy link

No description provided.

ljharb
ljharb reviewed Mar 26, 2021
View reviewed changes
Copy link
Owner

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird failures:

  • ./nvm_stdout_is_terminal: line 28: /dev/tty: No such device or address
  • tput: unknown terminal "unknown"
  • /home/runner/work/nvm/nvm/node_modules/.bin/urchin: 66: ./Running 'nvm ls' should not show a trailing slash: not found

.github/workflows/tests.yml Outdated
Comment on lines 13 to 24
strategy:
matrix:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
strategy:
matrix:
strategy:
fail-fast: false
matrix:

this way one failure won't stop the rest from finishing

@ljharb ljharb force-pushed the master branch 6 times, most recently from 5dce4f3 to 3fea549 Compare April 1, 2021 23:10
@ljharb ljharb force-pushed the master branch 5 times, most recently from da76c13 to 26b8624 Compare April 26, 2021 19:57
@ljharb ljharb force-pushed the master branch 5 times, most recently from f26e662 to eed0d0e Compare May 3, 2021 21:26
@ljharb ljharb force-pushed the master branch 6 times, most recently from 1aa765e to 5b77f7d Compare September 1, 2021 19:50
@ljharb ljharb force-pushed the master branch 26 times, most recently from 5edfb00 to c31a867 Compare August 20, 2024 23:30
@ljharb ljharb force-pushed the master branch 4 times, most recently from 37a3f7b to 179d450 Compare August 27, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@gsmanwar gsmanwar gsmanwar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sladyn98 @ljharb @gsmanwar