Make the code clear and easy to add functions #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 5, 2017 23:51
All the conversion code move to the other file.
|
I want to remind, if it matters: Light is not saved into the level data anymore, but calculated within 0.8 seconds while loading chunks according to tommaso. |
inxomnyaa
approved these changes
Jul 6, 2017
| case (byte) 248: //info_update | ||
| case (byte) 249: //info_update2 | ||
| case (byte) 250: //movingblock | ||
| case (byte) 251: //observer |
There was a problem hiding this comment.
I forgot to check it, already fixed :)
|
That's OK. That's why I chose to ignore light data whether it exists. |
|
Huge thanks to you guys! Really appreciate you guys do the refactoring job for me! And nice code compare with my messy code:) I am not a great programmer and I program just for fun, thanks for helping me out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This is a cool program that help me a lot, so I want to do something to help improving it.
The followings below are some changes I made:
btw I found a site which shows almost all meaning of each tag in MCPE LevelDb.
It may be useful for programming, i think :)
https://minecraft.gamepedia.com/User:Jocopa3/Pocket_Level_Format_Test#LevelDB_Format