Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arabic: Add new local datasets, starting by ar-dz #1588

Merged
merged 75 commits into from
Sep 13, 2024

Conversation

linuxscout
Copy link
Contributor

I have made things!

Checklist

  • I have read contributing guidelines

  • I'm sure that I did not unrelated changes in this pull request

  • I have created at least one test case for the changes I have made

  • I have added myself to the CONTRIBUTORS.rst

Related issues

"عين البنيان",
"عين البيضاء",
"عين الترك",
"عين التركي",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know Arabic is a right-to-left (RTL) language, but the indentation seems incorrect here. Could you please format all these files using JSON Online Editor or a similar tool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, done

{
"day": {
"abbr": [
"س",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, done

@lk-geimfari
Copy link
Owner

Please fix the tests and issues mentioned above, and then this PR will be ready to merge.

@lk-geimfari
Copy link
Owner

Also, it would be great to add Algeria to this list: https://github.com/lk-geimfari/mimesis/blob/master/docs/locales.rst#supported-locales

@linuxscout
Copy link
Contributor Author

Also, it would be great to add Algeria to this list: https://github.com/lk-geimfari/mimesis/blob/master/docs/locales.rst#supported-locales

ok, done.

mimesis/enums.py Outdated Show resolved Hide resolved
@lk-geimfari
Copy link
Owner

Well, we’re almost done. Can you please address the failed tests?

To fix the formatting, run the following command:

make format

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.20%. Comparing base (6807849) to head (a9644a9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1588      +/-   ##
==========================================
- Coverage   56.33%   56.20%   -0.14%     
==========================================
  Files          60       60              
  Lines        2178     2185       +7     
==========================================
+ Hits         1227     1228       +1     
- Misses        951      957       +6     

@linuxscout
Copy link
Contributor Author

Is there anything to do?

@lk-geimfari
Copy link
Owner

Is there anything to do?

That's it. Thank you. I'll merge this PR on this weekend and release new version soon.

@lk-geimfari lk-geimfari merged commit 931ea79 into lk-geimfari:master Sep 13, 2024
12 of 13 checks passed
@lk-geimfari
Copy link
Owner

lk-geimfari commented Sep 13, 2024

@linuxscout https://github.com/lk-geimfari/mimesis/releases/tag/v18.0.0

Thank you all guys!

@lk-geimfari
Copy link
Owner

@linuxscout Can you please look at this test fail:

https://github.com/lk-geimfari/mimesis/actions/runs/10856979200/job/30132622505

Unfortunately it's hard for me to understand what's wrong as I don't know the language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants