-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arabic: Add new local datasets, starting by ar-dz #1588
Conversation
"عين البنيان", | ||
"عين البيضاء", | ||
"عين الترك", | ||
"عين التركي", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know Arabic is a right-to-left (RTL) language, but the indentation seems incorrect here. Could you please format all these files using JSON Online Editor or a similar tool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, done
mimesis/datasets/ar/datetime.json
Outdated
{ | ||
"day": { | ||
"abbr": [ | ||
"س", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, done
Please fix the tests and issues mentioned above, and then this PR will be ready to merge. |
Also, it would be great to add Algeria to this list: https://github.com/lk-geimfari/mimesis/blob/master/docs/locales.rst#supported-locales |
- fix egypt VR code into EG, since 2024.
ok, done. |
Update address.json
Update ar-om
Update CONTRIBUTORS.rst add my credit for ar-om patch
Update address.json
Update address.json
Well, we’re almost done. Can you please address the failed tests? To fix the formatting, run the following command:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1588 +/- ##
==========================================
- Coverage 56.33% 56.20% -0.14%
==========================================
Files 60 60
Lines 2178 2185 +7
==========================================
+ Hits 1227 1228 +1
- Misses 951 957 +6 |
Is there anything to do? |
That's it. Thank you. I'll merge this PR on this weekend and release new version soon. |
@linuxscout https://github.com/lk-geimfari/mimesis/releases/tag/v18.0.0 Thank you all guys! |
@linuxscout Can you please look at this test fail: https://github.com/lk-geimfari/mimesis/actions/runs/10856979200/job/30132622505 Unfortunately it's hard for me to understand what's wrong as I don't know the language. |
I have made things!
Checklist
I have read contributing guidelines
I'm sure that I did not unrelated changes in this pull request
I have created at least one test case for the changes I have made
I have added myself to the CONTRIBUTORS.rst
Related issues