Fixed bug for special synthetic attributes nuking non-synthetic attri…

…butes starting with an underscore
lkarlslund · Sep 16, 2022 · 3defec2 · 3defec2
1 parent 600eccb
commit 3defec2
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/modules/query/ldapparser.go b/modules/query/ldapparser.go
@@ -243,17 +243,15 @@ valueloop:
 				}
 			}
 			return s, pwnquery{attributename == "_canpwn", edge, target}, nil
-			// default:
-			// 	return "", nil, fmt.Errorf("Unknown synthetic attribute %v", attributename)
 		}
-	} else {
-		attribute := engine.A(attributename)
-		if attribute == engine.NonExistingAttribute {
-			return nil, nil, fmt.Errorf("Unknown attribute %v", attributename)
-		}
-		attributes = []engine.Attribute{attribute}
 	}
 
+	attribute := engine.A(attributename)
+	if attribute == engine.NonExistingAttribute {
+		return nil, nil, fmt.Errorf("Unknown attribute %v", attributename)
+	}
+	attributes = []engine.Attribute{attribute}
+
 	attribute2 := engine.NonExistingAttribute
 	if attributename2 != "" {
 		attribute2 = engine.A(attributename2)