Saved one allocation when returning SIDs

lkarlslund · Jun 13, 2022 · 4e4e728 · 4e4e728
1 parent dd304ce
commit 4e4e728
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/modules/windowssecurity/sid.go b/modules/windowssecurity/sid.go
@@ -33,12 +33,11 @@ func ParseSID(data []byte) (SID, []byte, error) {
 		return "", data, fmt.Errorf("SID revision must be 1 (dump %x ...)", data)
 	}
 	subauthoritycount := int(data[1])
-	var sid = make([]byte, 8+4*subauthoritycount)
 	if subauthoritycount > 15 {
 		return "", data, errors.New("SID subauthority count is more than 15")
 	}
-	copy(sid, data[0:len(sid)])
-	return SID(dedup.D.S(string(sid))), data[len(sid):], nil
+	length := 8 + 4*subauthoritycount
+	return SID(dedup.D.BS(data[0:length])), data[length:], nil
 }
 
 func SIDFromString(input string) (SID, error) {