This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
feat: llama message broadcaster #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xrajath
commented
Jan 12, 2024
Comment on lines
+16
to
+17
| // Duck testing to check if the caller is a Llama instance. | ||
| ILlamaCore(llamaExecutor.LLAMA_CORE()).actionsCount(); |
There was a problem hiding this comment.
Adding the duck test here to reduce possible spam since it's an open function.
0xrajath
commented
Jan 12, 2024
There was a problem hiding this comment.
I could have made a separate deployer script for just the LlamaMessageBroadcaster. I'm not opposed to the idea, but I think this would be simpler to manage.
|
Coverage after merging rajath/llama-broadcast into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want to enable llama instances to arbitrarily broadcast messages. This can be used to voice an opinion on a social issue, to recommend an offchain software version number, or to make a prediction. The message can be a structured JSON blob or unstructured prose.
Modifications:
LlamaMessageBroadcasterperipheral contract.DeployLlamaTokenVotingFactoryforge script to include theLlamaMessageBroadcasterdeployment.Result:
Llama instances can now broadcast arbitrary offchain messages though a new broadcaster module.