Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

test: create more VertexCore tests #209

Merged
merged 6 commits into from
Apr 6, 2023

Conversation

AustinGreen
Copy link
Contributor

Motivation:

Close #187

Modifications:

Completed the TODOs in VertexCore besides the signature functions that will be merged in #208 and integration tests.

Result:

VertexCore test coverage will improve.

Copy link
Collaborator

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tiny things

src/VertexCore.sol Outdated Show resolved Hide resolved
test/VertexCore.t.sol Outdated Show resolved Hide resolved
test/VertexCore.t.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@0xrajath 0xrajath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though I think you should address @mds1 comments first. They're pretty good points

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Coverage after merging austin/vertex-core-followup-tests into main will be

89.57%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   VertexAccount.sol100%100%100%100%
   VertexCore.sol91%87.93%85%93.44%279, 286–287, 287, 287–288, 313, 320–321, 321, 321–322, 427, 499, 503
   VertexFactory.sol100%100%100%100%
   VertexLens.sol100%100%100%100%
   VertexPolicy.sol87.40%77.78%90%88.61%142, 185–186, 188, 240–241, 246, 251–252, 271, 327, 336, 374
   VertexPolicyMetadata.sol100%100%100%100%
   VertexStrategy.sol97.96%83.33%100%100%178
src/lib
   Checkpoints.sol79.68%72.22%94.44%80.87%105, 204, 216–217, 258–260, 260, 260–261, 263, 266, 294–295, 333–335, 337–339, 341–343, 345–347, 349–351, 353–355, 361–362, 380, 389, 53
   ERC721NonTransferableMinimalProxy.sol72.46%72.73%72.73%72.22%102, 104, 106, 118, 190, 88, 88, 88, 90, 90, 90, 92, 92, 92, 97, 99

@AustinGreen AustinGreen merged commit 16d7e02 into main Apr 6, 2023
@AustinGreen AustinGreen deleted the austin/vertex-core-followup-tests branch April 6, 2023 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: implement VertexCore unit tests
3 participants