[Issue #235 fix] Fixed scroll on reordering activities

[dhruvmisra]

Fixes #235
Removed the jquery-sortable dependency and handling the sorting and drag-and-drops using the already existing jquery-ui dependency. Calling the updateActivities() function only when the list has been updated reducing the unnecessary server calls. Also added a smooth animation while reordering.

[NikhilM98]

This will cause the List Chart view to crash. Fix it there too:

[dhruvmisra]

@NikhilM98 Fixed the problem in my latest commit. Please review.

[NikhilM98]

Can you run npm run lint and fix the indentation.

[dhruvmisra]

@NikhilM98 Something weird, the file had correct indentation on my IDE but messed some of it after the push. Fixed it nevertheless.

[NikhilM98]

Removed the jquery-sortable dependency

• The dependency is still present (dashboard/public/js/jquery-sortable.js).
• Can you add dashboard/public/js/jquery.ui.sortable-animation.js to .eslintignore and remove the deleted files from there too.

[dhruvmisra]

@NikhilM98 Made the required changes.

[NikhilM98]

There are too many unnecessary changes in main.js. Can you limit the changes to your code (minimum required).

[dhruvmisra]

That was the result of linting the file. All the indentations and spaces were reset which are showing up as new changes on git. The only changes I made were in initDragDrop() and initChartDragDrop().

[NikhilM98]

Yes, spaces were added in the whole file and those changes are unnecessary.

[dhruvmisra]

@NikhilM98 Removed the unnecessary spaces.

[llaske]

Nice. Thanks.