Skip to content

Commit

Permalink
dump-autoload box setting should be applied only if not previously de…
Browse files Browse the repository at this point in the history
…fined
  • Loading branch information
llaville committed Oct 3, 2024
1 parent a7cacad commit f5f8972
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
3 changes: 3 additions & 0 deletions .changes/unreleased/Fixed-20241003-072041.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kind: Fixed
body: '[GH-13](https://github.com/llaville/box-manifest/issues/13) : v4.0.0-rc.1 does not support correctly the BOX dump-autoload setting'
time: 2024-10-03T07:20:41.299069779Z
3 changes: 2 additions & 1 deletion box.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@
"files-bin": [
"vendor/humbug/php-scoper/vendor-hotfix/.gitkeep"
],
"stub": "stub.php"
"stub": "stub.php",
"dump-autoload": true
}
2 changes: 1 addition & 1 deletion box.json.dist
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
".box.manifests.bin"
],
"stub": "stub.php",
"dump-autoload": false,
"dump-autoload": true,
"map": [
{
"console-table.txt": ".box.manifests/console-table.txt"
Expand Down
2 changes: 1 addition & 1 deletion src/Pipeline/ConfigureStage.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public function __invoke(array $payload): array

// @link Due to issue https://github.com/box-project/box/issues/580
// @see https://github.com/box-project/box/issues/580#issuecomment-2326577684
$configs['dump-autoload'] = false;
$configs['dump-autoload'] ??= false; // should be applied only if not previously defined

if (!isset($configs['files-bin'])) {
$configs['files-bin'] = [];
Expand Down

0 comments on commit f5f8972

Please sign in to comment.