Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrailingCommaSniff give wrong results #348

Closed
2 of 5 tasks
llaville opened this issue Mar 6, 2022 · 0 comments
Closed
2 of 5 tasks

TrailingCommaSniff give wrong results #348

llaville opened this issue Mar 6, 2022 · 0 comments
Assignees
Labels

Comments

@llaville
Copy link
Owner

llaville commented Mar 6, 2022

Bug report category

  • Installation issue.
  • Feature issue.
  • Source Code Analysis issue.
  • PHP extension related issue.
  • Other. Please specify in Summary section

Diagnose

Output of `diagnose` command
Requirements Checker
====================

 > Running PHP CompatInfo with PHP 7.4.28 on Linux 4.19.128-microsoft-standard
 > PHP is using the following php.ini file:
   WARNING: No configuration file (php.ini) used by PHP!

 > Checking PHP CompatInfo requirements:
   [x] PHP version must be at least 7.4.0
   [x] pdo_sqlite extension must be available
   [x] Check if source "/home/devilbox/.cache/bartlett/compatinfo-db.sqlite" can be reached
   [x] Check if tables exists in database
   [x] Check if database contains at least one distribution platform


 ? Environment
    >  [APP_ENV] prod
    >  [APP_DATABASE_URL] sqlite:////home/devilbox/.cache/bartlett/compatinfo-db.sqlite
    >  [APP_PROXY_DIR] /tmp/bartlett/php-compatinfo-db/4.1.0@b8969ae/proxies
    >  [APP_VENDOR_DIR] /shared/backups/bartlett/php-compatinfo/vendor
    >  [APP_CACHE_DIR] /home/devilbox/.cache/bartlett
    >  [APP_HOME_DIR] /home/devilbox


 [OK] Your system is ready to run the application.


 ! [NOTE] phpCompatInfo version 6.3.x-dev@efd410d DB version 4.1.0@b8969ae

Summary

When trying to detect trailing comma PHP feature that come with PHP 8.0, the TrailingCommaSniff fails to detect good results.

Expected behaviour

Expected PHP min value

Actual behaviour

Wrong PHP min value : given PHP 8.0.0alpha1

Feature issue.

Trailing comma

Source Code Analysis issue.

Source Code reference: https://github.com/laminas/laminas-mail/releases/tag/2.16.0

Thanks to @remicollet for issue #345 that allow me to found this bug !

@llaville llaville added the bug label Mar 6, 2022
@llaville llaville self-assigned this Mar 6, 2022
llaville added a commit that referenced this issue Mar 6, 2022
@llaville llaville closed this as completed Mar 6, 2022
llaville added a commit that referenced this issue Mar 6, 2022
* add a text manifest in PHAR distrib

* fix issue #345

* implement feature #346

* implement feature request #347

* clean-up old box manifest resources

* fix issue #348

* add experimental RuleReporter (use '--output rule' format)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant