Test & Solution for #31. #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songz
reviewed
Jun 12, 2017
test/31.js
Outdated
| @@ -18,4 +19,20 @@ describe('longest string in an array', () => { | |||
| it('the longest string in [just] is just', () => { | |||
| expect(solution(['just'])).eql('just'); | |||
| }) | |||
| it.only('the longest string in [hi,hello,hola] is hello', () => { | |||
| expect(solution1(['hi','hello','hola'])).eql('hello'); | |||
There was a problem hiding this comment.
Instead of creating 5 literally duplicate test cases, could you just take advantage of the test cases already written?
yjlim5
requested changes
Jun 13, 2017
solutions/31.js
Outdated
| while(i < arr.length){ | ||
| if (big.length < arr[i].length){ | ||
| big = arr[i]; | ||
| i++; |
There was a problem hiding this comment.
you should only need one i++
yjlim5
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.