add Miri CI #61
Merged
add Miri CI #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
commented
Aug 22, 2020
.travis.yml
Outdated
| @@ -39,6 +39,9 @@ matrix: | |||
| env: | |||
| - ARCH=x86_64 | |||
| - FEATURES="--features generic-simd,runtime-dispatch-simd" | |||
| - name: Miri | |||
| rust: nightly | |||
| script: ci/miri.sh | |||
There was a problem hiding this comment.
In terms of ordering it would probably be better to put Miri earlier as it will be one of the longer-running jobs I assume?
|
(Not sure what's happening with Travis, it doesn't show up in the PR for some reason but a job is running.) |
|
FWIW, Miri can also run code for other architectures, so this could help with #53. So far I only tested cross-OS interpretation (like using a Windows target on a Linux host and vice versa), but in principle using a different CPU as a target should also work. EDIT: did that, it works great. :) |
RalfJung
commented
Aug 22, 2020
|
|
||
| # Run tests | ||
| cargo miri test | ||
| cargo miri test --target=mips64-unknown-linux-gnuabi64 # big-endian architecture |
There was a problem hiding this comment.
I verified locally that reverting db2b9ef makes this test fail.
|
(CI fails for Rust 1.32 because criterion-0.3.3 does not seem compatible.) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long time ago, I think at RustFest Rome, we talked about using Miri to test bytecount. Back then Miri wasn't up for the task, but these days it is. :)
In the default settings, each quickcheck test takes around 50s in Miri on my machine, which seems okay. When running the tests locally, one can make things go faster with something like
("disable-isolation" is needed to forward the env var to the program)
Note that by default Miri makes all RNGs deterministic. We could add the
-Zmiri-disable-isolationflag to allow seeing from the OS RNG.Also fixes #53.