Update edition from 2018 to 2021 #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update formatting using `cargo fmt`. - Update import statements from `extern crate` to `use`. - Update `criterion` version to `0.5.1`
|
@llogiq can you review it? |
|
I need to test it locally. Our CI is currently totally borked. |
|
Sorry, but updating to edition 2021 would break our minimum-supported Rust version (msrv) policy. The current minimum supported version is 1.32.0. I'll have to look if we need to update to a newer version to support neon intrinsics (which I plan on doing) or perhaps WASM (which might be added later), and if yes, we might make the jump if and only if that version also supports edition 2021. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo fmt.extern cratetouse.criterionversion to0.5.1