Memory leak in yajl_tree_parse with invalid JSON in v2.0.4 and older

[andrew78]

This patch will fix it.

Index: yajl_tree.c
===================================================================
--- yajl_tree.c (revision xxx)
+++ yajl_tree.c (revision xxx)
@@ -144,6 +144,9 @@
 
     v = stack->value;
 
+    if (stack->key != NULL)
+      free(stack->key);
+
     free (stack);
 
     return (v);
@@ -444,6 +447,11 @@
              snprintf(error_buffer, error_buffer_size, "%s", internal_err_str);
              YA_FREE(&(handle->alloc), internal_err_str);
         }
+        while(ctx.stack != NULL)
+        {
+          yajl_val v = context_pop(&ctx);
+          yajl_tree_free(v);
+        }
         yajl_free (handle);
         return NULL;
     }

[DhirajS]

In some corner cases when the stack has been emptied due to an error, the ctx.root can still be leaking memory. I have found this patch to fix all the leaks we have encountered. Love to hear more thoughts on this.

diff --git a/yajl_tree.c b/yajl_tree.c
index e63240c..ed09349 100644
--- a/yajl_tree.c
+++ b/yajl_tree.c
@@ -143,6 +143,7 @@ static yajl_val context_pop(context_t *ctx)
     ctx->stack = stack->next;

     v = stack->value;
+    free(stack->key);

     free (stack);

@@ -444,6 +445,12 @@ yajl_val yajl_tree_parse (const char *input,
              snprintf(error_buffer, error_buffer_size, "%s", internal_err_str);
              YA_FREE(&(handle->alloc), internal_err_str);
         }
+        while(ctx.stack != NULL)
+        {
+          yajl_val v = context_pop(&ctx);
+          yajl_tree_free(v);
+        }
+        yajl_tree_free(ctx.root);
         yajl_free (handle);
         return NULL;
     }