Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty assignation of samples #51

Closed
llrs opened this issue May 7, 2024 · 2 comments
Closed

Faulty assignation of samples #51

llrs opened this issue May 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@llrs
Copy link
Owner

llrs commented May 7, 2024

There were two samples that the allocation was not correct.
This is related to the data from #47 (Olink-NeuroEpiCas).
In each plate (index 1) there were two samples to the same well.

It could be either spatial is faulty or inspect is faulty.
I could manually resolve the issue by using position_name.
The reason seems that plate 1 didn't use the well that was assigned to plate 2.
And vice versa, so both plates ended up with problems.

Consider exporting position_name and add more internal checks of the output of spatial and inspect.

@llrs llrs added the bug Something isn't working label May 7, 2024
llrs added a commit that referenced this issue May 7, 2024
Related to #51.

Might need to check code
@llrs
Copy link
Owner Author

llrs commented May 7, 2024

Also check and reorder the spatial index according to positions

@llrs
Copy link
Owner Author

llrs commented May 8, 2024

position_name returns a factor with all the possible positions so that will help to sort them.
The commit fixed the issue with the code and it is simpler and faster.

@llrs llrs closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant