Skip to content

Commit

Permalink
Split dependencies for app and actor/model
Browse files Browse the repository at this point in the history
Actors and models are libraries, so they should provide ranges of
dependencies, but apps should always have their dependencies pinned.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
  • Loading branch information
llucax committed Nov 20, 2024
1 parent 465601d commit 25d0e6f
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 5 deletions.
12 changes: 10 additions & 2 deletions cookiecutter/{{cookiecutter.github_repo_name}}/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,22 @@ classifiers = [
]
requires-python = ">= 3.11, < 4"
# TODO(cookiecutter): Remove and add more dependencies if appropriate
{%- if cookiecutter.type in ("app", "actor", "model") %}
{%- if cookiecutter.type in ("actor", "model") %}
dependencies = [
"typing-extensions == 4.12.2",
"typing-extensions >= 4.12.2, < 5",
# Make sure to update the version for cross-referencing also in the
# mkdocs.yml file when changing the version here (look for the config key
# plugins.mkdocstrings.handlers.python.import)
"frequenz-sdk >= 1.0.0rc1300, < 1.0.0rc1400",
]
{%- elif cookiecutter.type == "app" %}
dependencies = [
"typing-extensions == 4.12.2",
# Make sure to update the version for cross-referencing also in the
# mkdocs.yml file when changing the version here (look for the config key
# plugins.mkdocstrings.handlers.python.import)
"frequenz-sdk == 1.0.0rc1300",
]
{%- elif cookiecutter.type == "api" %}
dependencies = [
"frequenz-api-common >= 0.6.2, < 0.7.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ classifiers = [
requires-python = ">= 3.11, < 4"
# TODO(cookiecutter): Remove and add more dependencies if appropriate
dependencies = [
"typing-extensions == 4.12.2",
"typing-extensions >= 4.12.2, < 5",
# Make sure to update the version for cross-referencing also in the
# mkdocs.yml file when changing the version here (look for the config key
# plugins.mkdocstrings.handlers.python.import)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ dependencies = [
# Make sure to update the version for cross-referencing also in the
# mkdocs.yml file when changing the version here (look for the config key
# plugins.mkdocstrings.handlers.python.import)
"frequenz-sdk >= 1.0.0rc1300, < 1.0.0rc1400",
"frequenz-sdk == 1.0.0rc1300",
]
dynamic = ["version"]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ classifiers = [
requires-python = ">= 3.11, < 4"
# TODO(cookiecutter): Remove and add more dependencies if appropriate
dependencies = [
"typing-extensions == 4.12.2",
"typing-extensions >= 4.12.2, < 5",
# Make sure to update the version for cross-referencing also in the
# mkdocs.yml file when changing the version here (look for the config key
# plugins.mkdocstrings.handlers.python.import)
Expand Down

0 comments on commit 25d0e6f

Please sign in to comment.