Fixed point test cases #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that the LLVM test suite is the right home for this test. It introduces a dependency from the test suite onto the SDK. We purposely made llvm-mos not depend on the SDK, so that the SDK could be swapped out or rewritten later. Perhaps it should live somewhere in llvm-mos-sdk. |
|
@johnwbyrd this repo already has test cases for sdk classes like soa.h. I put the tests here as mysterymath asked me to do that. While it could be good direction to change that moving forward, I don't think this PR needs to do the refactoring to move sdk tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial test cases for fixed point numbers