Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OM] Missing Verifier on Class Op return Type #7735

Closed
seldridge opened this issue Oct 26, 2024 · 2 comments
Closed

[OM] Missing Verifier on Class Op return Type #7735

seldridge opened this issue Oct 26, 2024 · 2 comments
Assignees
Labels
bug Something isn't working OM Object Model

Comments

@seldridge
Copy link
Member

Currently, there is no verifier that the type of an om.class correctly matches the new om.class.fields terminator.

Consider the following:

om.class @A(%arg: i1) {
  om.class.fields %arg : i1
}

Currently, circt-opt will accept this. However, the type should be verified to be:

om.class @A(%arg: i1) -> (a: i1) {
  om.class.fields %arg : i1
}
@seldridge seldridge added bug Something isn't working OM Object Model labels Oct 26, 2024
@seldridge seldridge self-assigned this Oct 28, 2024
@mikeurbach
Copy link
Contributor

Thanks for filing this. There is also #7078, but that is more about adding back a local verifier on object.field. I think this one is more about a local verifier on class.fields, which we should also have. @leonardt can you please take a look?

@seldridge
Copy link
Member Author

Fixed via: e080112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OM Object Model
Projects
None yet
Development

No branches or pull requests

3 participants