[CIR][CodeGen][NFC] centralized split std::initializer_list field
#1235
+64
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use iterator to visit std::initializer_list field reduce the readability
|
Is this just moving the content from the declaration to the outline definition or is there anything else going on? It's hard to spot. If so, this LGTM. If not, is this making code more similar to |
The code do the same thing with before. What I do is dereferencing mutable iterator to immutable field pointers to improve readability. I think it does not related to skeleton since codegen logic is still in place. |
bcardosolopes
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use iterator to visit std::initializer_list field reduce the readability