Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRGen][Builtin][Neon] Lower neon_vmax_v and neon_vmaxq_v #1239

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ghehg
Copy link
Collaborator

@ghehg ghehg commented Dec 18, 2024

This implementation is different from OG in the sense we chose to use CIR op which eventually lowers to generic LLVM intrinsics instead of llvm.aarch64.neon intrinsics
But down to the ASM level, they are identical .

@ghehg ghehg marked this pull request as ready for review December 18, 2024 15:26
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for finding a generic way to solve this, way to go.

@bcardosolopes bcardosolopes merged commit 710fa7f into llvm:main Dec 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants