Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][CIRGen][TBAA] Replace hardcoded TBAA names with getTBAAName #1242

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[CIR][CIRGen][TBAA] Replace hardcoded TBAA names with getTBAAName #1242

merged 1 commit into from
Dec 19, 2024
+80 −13

Conversation

PikachuHyA
Copy link
Collaborator

This patch follows #1220 (comment) by augmenting CIR_Type with a new field, tbaaName. Specifically, it enables TableGen support for the -gen-cir-tbaa-name-lowering option, allowing for the generation of getTBAAName functions based on the tbaaName. This enhancement enables us to replace the hardcoded TBAA names in the getTypeName function with the newly generated getTBAAName.

@PikachuHyA PikachuHyA mentioned this pull request Dec 19, 2024
Merged
bcardosolopes
bcardosolopes approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a bunch

@bcardosolopes bcardosolopes merged commit 445f2a5 into llvm:main Dec 19, 2024
7 checks passed
bcardosolopes added a commit that referenced this pull request Dec 20, 2024
@bcardosolopes
Revert "[CIR][CIRGen][TBAA] Replace hardcoded TBAA names with getTBAA…
adae4ff 
…Name (#1242)"

Need to revert #1220

This reverts commit 445f2a5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PikachuHyA @bcardosolopes