[CIR][CIRGen][TBAA][NFC] Skeleton for union, enum and bitint #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
changed the title
bcardosolopes
requested changes
Dec 20, 2024
| if (!codeGenOpts.PointerTBAA) { | ||
| return cir::TBAAScalarAttr::get(mlirContext, types.ConvertType(qty)); | ||
| } | ||
| llvm_unreachable("NYI"); |
There was a problem hiding this comment.
The same problems we discussed about llvm_unreachable before is valid for the whole implementation of TBAA, please move to missing features for here, elsewhere and any future work
|
Please make this only change enough to fix #1246, seems to be adding more than necessary for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1246
While following the structure of the original code generation, I overlooked the
getTypeInfoHelperfunction, which resulted in unions not being handled appropriately. see #1220 .In this patch, I have implemented the
getTypeInfoHelperfunction and marked enum and bitint as NYI.For further details, please refer to the specific commit: llvm/llvm-project@a5986b9#diff-9964470fc240f2670aab82f768ff846ce19ea37a06a47cd7b4599fa3ef92165cL109.