Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][CodeGen] codegen of lvalue comma expression #376

Merged
merged 1 commit into from
Jan 4, 2024
Merged

[CIR][CodeGen] codegen of lvalue comma expression #376

merged 1 commit into from
Jan 4, 2024

Conversation

Lancern
Copy link
Member

@Lancern Lancern commented Jan 2, 2024

Currently, codegen of lvalue comma expression would crash:

int &foo1();
int &foo2();

void c1() {
    int &x = (foo1(), foo2());  // CRASH
}

This simple patch fixes this issue.

bcardosolopes
bcardosolopes approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcardosolopes bcardosolopes merged commit 3adad6b into llvm:main Jan 4, 2024
6 checks passed
@Lancern Lancern deleted the comma-lvalue-codegen branch January 5, 2024 13:39
lanza pushed a commit that referenced this pull request Jan 29, 2024
@Lancern @lanza
[CIR][CIRGen] Lvalues and comma expression (#376)
37a46b2 
Currently, codegen of lvalue comma expression would crash:

```cpp
int &foo1();
int &foo2();

void c1() {
    int &x = (foo1(), foo2());  // CRASH
}
```

This simple patch fixes this issue.
lanza pushed a commit that referenced this pull request Mar 23, 2024
@Lancern @lanza
[CIR][CIRGen] Lvalues and comma expression (#376)
361ed3d 
Currently, codegen of lvalue comma expression would crash:

```cpp
int &foo1();
int &foo2();

void c1() {
    int &x = (foo1(), foo2());  // CRASH
}
```

This simple patch fixes this issue.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@Lancern @lanza
[CIR][CIRGen] Lvalues and comma expression (llvm#376)
37732f8 
Currently, codegen of lvalue comma expression would crash:

```cpp
int &foo1();
int &foo2();

void c1() {
    int &x = (foo1(), foo2());  // CRASH
}
```

This simple patch fixes this issue.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@Lancern @lanza
[CIR][CIRGen] Lvalues and comma expression (llvm#376)
77a7f9c 
Currently, codegen of lvalue comma expression would crash:

```cpp
int &foo1();
int &foo2();

void c1() {
    int &x = (foo1(), foo2());  // CRASH
}
```

This simple patch fixes this issue.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@Lancern @lanza
[CIR][CIRGen] Lvalues and comma expression (#376)
7a249ff 
Currently, codegen of lvalue comma expression would crash:

```cpp
int &foo1();
int &foo2();

void c1() {
    int &x = (foo1(), foo2());  // CRASH
}
```

This simple patch fixes this issue.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@Lancern @lanza
[CIR][CIRGen] Lvalues and comma expression (#376)
5655bf8 
Currently, codegen of lvalue comma expression would crash:

```cpp
int &foo1();
int &foo2();

void c1() {
    int &x = (foo1(), foo2());  // CRASH
}
```

This simple patch fixes this issue.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@Lancern @lanza
[CIR][CIRGen] Lvalues and comma expression (llvm#376)
14ac38f 
Currently, codegen of lvalue comma expression would crash:

```cpp
int &foo1();
int &foo2();

void c1() {
    int &x = (foo1(), foo2());  // CRASH
}
```

This simple patch fixes this issue.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@Lancern @lanza
[CIR][CIRGen] Lvalues and comma expression (#376)
2bde4fe 
Currently, codegen of lvalue comma expression would crash:

```cpp
int &foo1();
int &foo2();

void c1() {
    int &x = (foo1(), foo2());  // CRASH
}
```

This simple patch fixes this issue.
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
@Lancern @lanza
[CIR][CIRGen] Lvalues and comma expression (llvm#376)
261ad67 
Currently, codegen of lvalue comma expression would crash:

```cpp
int &foo1();
int &foo2();

void c1() {
    int &x = (foo1(), foo2());  // CRASH
}
```

This simple patch fixes this issue.
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@Lancern @lanza
[CIR][CIRGen] Lvalues and comma expression (llvm#376)
963a0a7 
Currently, codegen of lvalue comma expression would crash:

```cpp
int &foo1();
int &foo2();

void c1() {
    int &x = (foo1(), foo2());  // CRASH
}
```

This simple patch fixes this issue.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@Lancern @lanza
[CIR][CIRGen] Lvalues and comma expression (llvm#376)
aadbb77 
Currently, codegen of lvalue comma expression would crash:

```cpp
int &foo1();
int &foo2();

void c1() {
    int &x = (foo1(), foo2());  // CRASH
}
```

This simple patch fixes this issue.
lanza pushed a commit that referenced this pull request Nov 5, 2024
@Lancern @lanza
[CIR][CIRGen] Lvalues and comma expression (#376)
5385ea6 
Currently, codegen of lvalue comma expression would crash:

```cpp
int &foo1();
int &foo2();

void c1() {
    int &x = (foo1(), foo2());  // CRASH
}
```

This simple patch fixes this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lancern @bcardosolopes