Skip to content

Commit

Permalink
[libunwind] Remove the legacy Unwind_AppleExtras.cpp
Browse files Browse the repository at this point in the history
Unwind_AppleExtras.cpp contained annotations telling the linker that
some symbols are not available on some very old platforms. However,
those platforms are not supported anymore, so the annotations are not
used.

Why remove this? In addition to cleaning up the code base, this also
removes the possibility of implementing those annotations incorrectly
(which was the case previously), which could lead to important symbols
being hidden when they should have been visible.

Differential Revision: https://reviews.llvm.org/D148445
  • Loading branch information
ldionne committed Apr 18, 2023
1 parent 95cb986 commit 1ae57fe
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 126 deletions.
5 changes: 0 additions & 5 deletions libunwind/src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ set(LIBUNWIND_CXX_SOURCES
Unwind-EHABI.cpp
Unwind-seh.cpp
)
if(APPLE)
list(APPEND LIBUNWIND_CXX_SOURCES
Unwind_AppleExtras.cpp
)
endif()

if(${CMAKE_SYSTEM_NAME} MATCHES "AIX")
list(APPEND LIBUNWIND_CXX_SOURCES
Expand Down
121 changes: 0 additions & 121 deletions libunwind/src/Unwind_AppleExtras.cpp

This file was deleted.

0 comments on commit 1ae57fe

Please sign in to comment.