Skip to content

Commit

Permalink
[IRCE] Skip icmp ptr in InductiveRangeCheck::parseRangeCheckICmp (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
dtcxzyw authored Apr 26, 2024
1 parent bc8a4ea commit 22da5a6
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 0 deletions.
3 changes: 3 additions & 0 deletions llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,9 @@ bool InductiveRangeCheck::parseRangeCheckICmp(Loop *L, ICmpInst *ICI,
Value *LHS = ICI->getOperand(0);
Value *RHS = ICI->getOperand(1);

if (!LHS->getType()->isIntegerTy())
return false;

// Canonicalize to the `Index Pred Invariant` comparison
if (IsLoopInvariant(LHS)) {
std::swap(LHS, RHS);
Expand Down
33 changes: 33 additions & 0 deletions llvm/test/Transforms/IRCE/pr89959.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 4
; RUN: opt -passes=irce -S < %s 2>&1 | FileCheck %s

; Make sure we don't crash.
define void @pr89959() {
; CHECK-LABEL: define void @pr89959() {
; CHECK-NEXT: top:
; CHECK-NEXT: br label [[L3:%.*]]
; CHECK: L3:
; CHECK-NEXT: [[VALUE_PHI:%.*]] = phi ptr [ null, [[TOP:%.*]] ], [ [[TMP0:%.*]], [[L13:%.*]] ]
; CHECK-NEXT: [[TMP0]] = getelementptr i8, ptr [[VALUE_PHI]], i64 8
; CHECK-NEXT: [[DOTNOT:%.*]] = icmp ule ptr [[VALUE_PHI]], null
; CHECK-NEXT: br i1 [[DOTNOT]], label [[L13]], label [[L15:%.*]]
; CHECK: L13:
; CHECK-NEXT: br label [[L3]]
; CHECK: L15:
; CHECK-NEXT: ret void
;
top:
br label %L3

L3:
%value_phi = phi ptr [ null, %top ], [ %0, %L13 ]
%0 = getelementptr i8, ptr %value_phi, i64 8
%.not = icmp ule ptr %value_phi, null
br i1 %.not, label %L13, label %L15

L13:
br label %L3

L15:
ret void
}

0 comments on commit 22da5a6

Please sign in to comment.