Skip to content

Commit

Permalink
[AMDGPU][AsmParser][NFC] Remove a misleading comment. (#102604)
Browse files Browse the repository at this point in the history
The work of ParseRegularReg() should remain to be parsing the register
as it was specified, and not to try translate it to anything else.

It's up to operand predicates to decide on what is and is not an
acceptable register for an operand, including considering its expected
register class, and for the rest of the AsmParser infrastructure to
handle it respectively from there on.
  • Loading branch information
kosarev authored Aug 9, 2024
1 parent 9e9fa00 commit 52220c2
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2937,10 +2937,6 @@ unsigned AMDGPUAsmParser::ParseRegularReg(RegisterKind &RegKind,
StringRef RegSuffix = RegName.substr(RI->Name.size());
unsigned SubReg = NoSubRegister;
if (!RegSuffix.empty()) {
// We don't know the opcode till we are done parsing, so we don't know if
// registers should be 16 or 32 bit. It is therefore mandatory to put .l or
// .h to correctly specify 16 bit registers. We also can't determine class
// VGPR_16_Lo128 or VGPR_16, so always parse them as VGPR_16.
if (RegSuffix.consume_back(".l"))
SubReg = AMDGPU::lo16;
else if (RegSuffix.consume_back(".h"))
Expand Down

0 comments on commit 52220c2

Please sign in to comment.