Skip to content

Commit

Permalink
[mlir:Bytecode] Use UNSUPPORTED instead of XFAIL for s390x
Browse files Browse the repository at this point in the history
Some tests still pass even though we don't claim big-endian support. Using
UNSUPPORTED is a better indicator than XFAIL that we don't guarantee that
the tests work.
  • Loading branch information
River707 committed Aug 23, 2022
1 parent 02c2ecb commit df4e637
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion mlir/test/Bytecode/general.mlir
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// RUN: mlir-opt -allow-unregistered-dialect -emit-bytecode %s | mlir-opt -allow-unregistered-dialect | FileCheck %s

// Bytecode currently does not support big-endian platforms
// XFAIL: s390x-
// UNSUPPORTED: s390x-

// CHECK-LABEL: "bytecode.test1"
// CHECK-NEXT: "bytecode.empty"() : () -> ()
Expand Down
2 changes: 1 addition & 1 deletion mlir/test/Bytecode/invalid/invalid-dialect_section.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// the dialect section.

// Bytecode currently does not support big-endian platforms
// XFAIL: s390x-
// UNSUPPORTED: s390x-

//===--------------------------------------------------------------------===//
// Dialect Name
Expand Down
2 changes: 1 addition & 1 deletion mlir/test/Bytecode/invalid/invalid-ir_section.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// the IR section.

// Bytecode currently does not support big-endian platforms
// XFAIL: s390x-
// UNSUPPORTED: s390x-

//===--------------------------------------------------------------------===//
// Operations
Expand Down
2 changes: 1 addition & 1 deletion mlir/test/Bytecode/invalid/invalid-string_section.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// the string section.

// Bytecode currently does not support big-endian platforms
// XFAIL: s390x-
// UNSUPPORTED: s390x-

//===--------------------------------------------------------------------===//
// Count
Expand Down
2 changes: 1 addition & 1 deletion mlir/test/Bytecode/invalid/invalid-structure.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// a bytecode file.

// Bytecode currently does not support big-endian platforms
// XFAIL: s390x-
// UNSUPPORTED: s390x-

//===--------------------------------------------------------------------===//
// Version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// the attribute/type offset section.

// Bytecode currently does not support big-endian platforms
// XFAIL: s390x-
// UNSUPPORTED: s390x-

//===--------------------------------------------------------------------===//
// Offset
Expand Down
2 changes: 1 addition & 1 deletion mlir/test/Bytecode/invalid/invalid_attr_type_section.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// the attribute/type offset section.

// Bytecode currently does not support big-endian platforms
// XFAIL: s390x-
// UNSUPPORTED: s390x-

//===--------------------------------------------------------------------===//
// Index
Expand Down

0 comments on commit df4e637

Please sign in to comment.