Skip to content

Commit

Permalink
[LLDB] Remove dead code (NFC) (#95713)
Browse files Browse the repository at this point in the history
The dead code is caught by PVS studio analyzer -
https://pvs-studio.com/en/blog/posts/cpp/1126/, fragment N12.

Warning message -
V523 The 'then' statement is equivalent to the 'else' statement.
Options.cpp 1212
  • Loading branch information
xgupta authored Jun 17, 2024
1 parent 15bb026 commit e4e350e
Showing 1 changed file with 6 additions and 15 deletions.
21 changes: 6 additions & 15 deletions lldb/source/Interpreter/Options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1197,21 +1197,12 @@ OptionElementVector Options::ParseForCompletion(const Args &args,
}
break;
case OptionParser::eOptionalArgument:
if (OptionParser::GetOptionArgument() != nullptr) {
option_element_vector.push_back(OptionArgElement(
opt_defs_index,
FindOriginalIndex(dummy_vec[OptionParser::GetOptionIndex() - 2],
args),
FindOriginalIndex(dummy_vec[OptionParser::GetOptionIndex() - 1],
args)));
} else {
option_element_vector.push_back(OptionArgElement(
opt_defs_index,
FindOriginalIndex(dummy_vec[OptionParser::GetOptionIndex() - 2],
args),
FindOriginalIndex(dummy_vec[OptionParser::GetOptionIndex() - 1],
args)));
}
option_element_vector.push_back(OptionArgElement(
opt_defs_index,
FindOriginalIndex(dummy_vec[OptionParser::GetOptionIndex() - 2],
args),
FindOriginalIndex(dummy_vec[OptionParser::GetOptionIndex() - 1],
args)));
break;
default:
// The options table is messed up. Here we'll just continue
Expand Down

0 comments on commit e4e350e

Please sign in to comment.