Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1614R2: The Mothership has Landed #100018

Closed
cjdb opened this issue Jul 22, 2024 · 1 comment · Fixed by #99375
Closed

P1614R2: The Mothership has Landed #100018

cjdb opened this issue Jul 22, 2024 · 1 comment · Fixed by #99375
Labels
c++20 libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. spaceship issues related to <=>
Milestone
LLVM 19.X Release

Comments

@cjdb
Copy link
Contributor

cjdb commented Jul 22, 2024 •
edited by ldionne
Loading

Link: https://wg21.link/p1614r2

I think this is currently tracked by https://libcxx.llvm.org/Status/Spaceship.html. We should consider creating a project or milestone for the remaining tasks.

BEGIN-RST-NOTES
``std::strong_order(long double, long double)`` is partly implemented.
END-RST-NOTES
@cjdb cjdb added libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. c++20 spaceship issues related to <=> labels Jul 22, 2024
@llvmbot
Copy link
Member

llvmbot commented Jul 22, 2024

@llvm/issue-subscribers-c-20

Author: Christopher Di Bella (cjdb)

I think this is currently tracked by https://libcxx.llvm.org/Status/Spaceship.html. We should consider creating a project or milestone for the remaining tasks.

@h-vetinari h-vetinari mentioned this issue Jul 23, 2024
Merged
mordante added a commit that referenced this issue Jul 25, 2024
@mordante
[libc++][spaceship] Marks P1614 as complete. (#99375)
3ce6f68 
Implements parts of:
- P1902R1 Missing feature-test macros 2017-2019

Completes:
- P1614R2 The Mothership has Landed

Fixes #100018
yuxuanchen1997 pushed a commit that referenced this issue Jul 25, 2024
@mordante @yuxuanchen1997
[libc++][spaceship] Marks P1614 as complete. (#99375)
24fc1be 
Summary:
Implements parts of:
- P1902R1 Missing feature-test macros 2017-2019

Completes:
- P1614R2 The Mothership has Landed

Fixes #100018

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60250621
@ldionne ldionne added this to the LLVM 19.X Release milestone Jul 25, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Jul 25, 2024
@tru tru moved this from Needs Triage to Done in LLVM Release Status Jul 26, 2024
mordante added a commit to mordante/llvm-project that referenced this issue Jul 26, 2024
@mordante
[libc++][spaceship] Marks P1614 as complete. (llvm#99375)
c47152b 
Implements parts of:
- P1902R1 Missing feature-test macros 2017-2019

Completes:
- P1614R2 The Mothership has Landed

Fixes llvm#100018
@mordante mordante mentioned this issue Jul 26, 2024
Merged
tru pushed a commit to mordante/llvm-project that referenced this issue Jul 30, 2024
@mordante @tru
[libc++][spaceship] Marks P1614 as complete. (llvm#99375)
3389604 
Implements parts of:
- P1902R1 Missing feature-test macros 2017-2019

Completes:
- P1614R2 The Mothership has Landed

Fixes llvm#100018
@ldionne ldionne changed the title Complete 'P1614R2 The Mothership has Landed' P1614R2: The Mothership has Landed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++20 libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. spaceship issues related to <=>
Projects
LLVM Release Status
Status: Done
libc++ Standards Conformance
Status: Done
Milestone
LLVM 19.X Release
Development

Successfully merging a pull request may close this issue.

[libc++][spaceship] Marks P1614 as complete. llvm/llvm-project
3 participants
@ldionne @cjdb @llvmbot