Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang-format] Regression in version 20 with macros #107096

Closed
prj- opened this issue Sep 3, 2024 · 3 comments
Closed

[clang-format] Regression in version 20 with macros #107096

prj- opened this issue Sep 3, 2024 · 3 comments

Comments

@prj-
Copy link

prj- commented Sep 3, 2024

$ clang-format dump
#define MACRO() \
  namespace std \
  { \
  template <> \
  struct hash<type> { \
    std::size_t operator()(const type &t) const noexcept \
    { \
      std::size_t ret = 0; \
      hash_combine(ret, __VA_ARGS__); \
      return ret; \
    } \
  }; \
  }
$ clang-format-20 dump
#define MACRO() \
  namespace std \
  { \
  template <> \
  struct hash<type>{std::size_t operator()(const type &t) const noexcept {std::size_t ret = 0; \
  hash_combine(ret, __VA_ARGS__); \
  return ret; \
  } \
  } \
  ; \
  }
$ clang-format-20 --version
Debian clang-format version 20.0.0 (++20240902101259+0ba006daf5d9-1~exp1~20240902221440.2311)
@prj-
Copy link
Author

prj- commented Sep 3, 2024

Debian clang-format version 20.0.0 (++20240831100704+8aa8c0590c09-1~exp1~20240831220720.2307) is clean, just FWIW, so this is due to a very recent change.

@rymiel
Copy link
Member

rymiel commented Sep 3, 2024

Bisected to 0fa78b6

@prj-
Copy link
Author

prj- commented Sep 3, 2024

Bingo. Why did this make it to 19 final release and not RC4!? #107058

@owenca owenca closed this as completed in 3449ed8 Sep 4, 2024
owenca added a commit to owenca/llvm-project that referenced this issue Sep 5, 2024
owenca added a commit that referenced this issue Sep 6, 2024
VitaNuo pushed a commit to VitaNuo/llvm-project that referenced this issue Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants