After c6e996a931f, Assertion failed: (Loc.isValid() && "point of instantiation must be valid!"), function setPointOfInstantiation #107777
Labels
clang:frontend
Language frontend issues, e.g. anything involving "Sema"
confirmed
Verified by a second party
crash
Prefer [crash-on-valid] or [crash-on-invalid]
Comments
DimitryAndric
added
the
clang:frontend
|
@llvm/issue-subscribers-clang-frontend Author: Dimitry Andric (DimitryAndric)
After `llvmorg-19-init-17412-g`c6e996a931f, which reverted `llvmorg-19-init-15785-g`567b2c608c30, which reverted `llvmorg-19-init-15760-g`5b363483cf24, I get the following assertion compiling qt5-webengine:
Minimized test case: // clang -cc1 -triple x86_64-- -S spellcheck_common-min.cpp
int find___proj, Contains___trans_tmp_2;
template <class, int __v> struct integral_constant {
static const int value = __v;
};
template <bool, class> using __enable_if_t = int;
template <class _Tp>
struct __libcpp_is_trivially_equality_comparable_impl
: integral_constant<bool, __is_trivially_equality_comparable(_Tp)> {};
template <class, class _Up>
using __libcpp_is_trivially_equality_comparable =
__libcpp_is_trivially_equality_comparable_impl<_Up>;
template <
class _Tp, class _Up, class _Proj,
__enable_if_t<__libcpp_is_trivially_equality_comparable<_Tp, _Up>::value,
int> = 0>
void __find(_Tp, _Up, _Proj);
template <class _Tp> void find(int __last, _Tp __value) {
__find(__last, __value, find___proj);
}
template <class> struct basic_string_view {};
typedef basic_string_view<int> __self_view;
struct basic_string {
operator __self_view() const;
};
class error_condition operator==(error_condition, error_condition);
basic_string Contains_value;
void Contains() { find(Contains___trans_tmp_2, Contains_value); }cc @philnik777, @AaronBallman, @ZequanWu |
|
Confirmed: https://godbolt.org/z/YsaseMMT8 |
|
Probably too late for 19.1.0, @tru ? Though it could be a simple revert of a revert of a revert :) |
|
I'd rather not revert, since the original fixed a (IMO) pretty serious bug. A crash seems much nicer than wrong code gen. |
Agreed - bad codegen is worse than a crash. But can we get a crash fix in this week we could pick it over to 19. |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this issue
Sep 11, 2024
…uality_comparable (llvm#107815) Fixes llvm#107777 (cherry picked from commit 6dbdb84)
VitaNuo
pushed a commit
to VitaNuo/llvm-project
that referenced
this issue
Sep 12, 2024
…uality_comparable (llvm#107815) Fixes llvm#107777
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this issue
Sep 16, 2024
…uality_comparable (llvm#107815) Fixes llvm#107777 (cherry picked from commit 6dbdb84)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After
llvmorg-19-init-17412-gc6e996a, which revertedllvmorg-19-init-15785-g567b2c6, which revertedllvmorg-19-init-15760-g5b36348, I get the following assertion compiling qt5-webengine:Minimized test case:
cc @philnik777, @AaronBallman, @ZequanWu
The text was updated successfully, but these errors were encountered: