Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in typescript generics formatting #108536

Closed
kadircet opened this issue Sep 13, 2024 · 9 comments · May be fixed by #108671
Closed

Regression in typescript generics formatting #108536

kadircet opened this issue Sep 13, 2024 · 9 comments · May be fixed by #108671

Comments

@kadircet
Copy link
Member

kadircet commented Sep 13, 2024

actual formatting (file name a.ts):

foo = new Bar < (id: int) => X | Y > ();

expected formatting:

foo = new Bar<(id: int) => X | Y>();
@kadircet
Copy link
Member Author

culprit seems to be 73c961a, cc @owenca, @rymiel

@llvmbot
Copy link
Member

llvmbot commented Sep 13, 2024

@llvm/issue-subscribers-clang-format

Author: kadir çetinkaya (kadircet)

actual formatting (file name `a.ts`): ``` foo = new Bar < (id: int) => X | Y > (); ```

expected formatting:

foo = new Bar &lt;(id: int) =&gt; X | Y&gt;();

@kadircet
Copy link
Member Author

looks like this was also cherry-picked into 19.x release #101112

@kadircet kadircet added c++ regression:19 Regression in 19 release labels Sep 23, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 23, 2024

@llvm/issue-subscribers-c-1

Author: kadir çetinkaya (kadircet)

actual formatting (file name `a.ts`): ``` foo = new Bar < (id: int) => X | Y > (); ```

expected formatting:

foo = new Bar&lt;(id: int) =&gt; X | Y&gt;();

@kadircet
Copy link
Member Author

as mentioned in #108671 (comment), this is not specific to js:

constexpr auto foo() { return FixedInt < N | M > (foo); }

@owenca
Copy link
Contributor

owenca commented Sep 24, 2024

See #108671 (comment).

@owenca
Copy link
Contributor

owenca commented Sep 25, 2024

as mentioned in #108671 (comment), this is not specific to js:

constexpr auto foo() { return FixedInt < N | M > (foo); }

Split to #109912.

@owenca
Copy link
Contributor

owenca commented Oct 8, 2024

actual formatting (file name a.ts):

foo = new Bar < (id: int) => X | Y > ();

expected formatting:

foo = new Bar<(id: int) => X | Y>();

This was fixed by #110408.

@owenca owenca closed this as completed Oct 8, 2024
@owenca
Copy link
Contributor

owenca commented Jan 26, 2025

as mentioned in #108671 (comment), this is not specific to js:

constexpr auto foo() { return FixedInt < N | M > (foo); }

See #124438.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants