Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memprof_meminfoblock.h leftover in CMakeLists LLVM14 #54777

Closed
hahn-absint opened this issue Apr 6, 2022 · 1 comment
Closed

memprof_meminfoblock.h leftover in CMakeLists LLVM14 #54777

hahn-absint opened this issue Apr 6, 2022 · 1 comment
Labels
cmake Build system in general and CMake in particular compiler-rt

Comments

@hahn-absint
Copy link

On branch for release 14, file memprof_meminfoblock.h is listed in compiler-rt/lib/memprof/CMakeLists.txt, but is no longer available in the repo as removed in commit 8306968.

This causes a cmake error when attempting to build.
@EugeneZelenko EugeneZelenko added cmake Build system in general and CMake in particular compiler-rt and removed new issue labels Apr 6, 2022
JOE1994 added a commit to JOE1994/llvm-project that referenced this issue Jun 12, 2024
@JOE1994
[compiler-rt] Remove 'memprof_meminfoblock.h' from MEMPROF_HEADERS (NFC)
cfce39a 
Commit 8306968 deleted file
`compiler-rt/lib/memprof/memprof_meminfoblock.h`, but didn't remove it from
MEMPROF_HEADERS in `compiler-rt/lib/memprof/CMakeLists.txt`.

Remove unneeded leftover line in `compiler-rt/lib/memprof/CMakeLists.txt`.

p.s.
GH llvm#54777 reported a llvm14 build failure due to the existence of the
leftover line, but I'm unable to reproduce the build failure with llvm19 trunk.
@JOE1994 JOE1994 mentioned this issue Jun 12, 2024
Merged
JOE1994 added a commit that referenced this issue Jun 14, 2024
@JOE1994
[compiler-rt] Remove 'memprof_meminfoblock.h' from MEMPROF_HEADERS (N…
3ecba1a 
…FC) (#95334)

Commit 8306968 deleted file
`compiler-rt/lib/memprof/memprof_meminfoblock.h`, but didn't remove it
from MEMPROF_HEADERS in `compiler-rt/lib/memprof/CMakeLists.txt`.

Remove unneeded leftover line in
`compiler-rt/lib/memprof/CMakeLists.txt`.

p.s.
GH #54777 reported a llvm14 build failure due to the existence of the
leftover line, but I'm unable to reproduce the build failure with llvm19
trunk.
@JOE1994
Copy link
Member

JOE1994 commented Jun 14, 2024 •
edited
Loading

With LLVM 19 trunk I'm unable to reproduce build failure, but I've removed the unneeded leftover line.

@JOE1994 JOE1994 closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmake Build system in general and CMake in particular compiler-rt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EugeneZelenko @JOE1994 @hahn-absint