Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++14] Enable sized deallocation by default #60061

Closed
ChuanqiXu9 opened this issue Jan 16, 2023 · 6 comments · Fixed by #83774 or #90373
Closed

[C++14] Enable sized deallocation by default #60061

ChuanqiXu9 opened this issue Jan 16, 2023 · 6 comments · Fixed by #83774 or #90373
Assignees
Labels
c++14 clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl'

Comments

@ChuanqiXu9
Copy link
Member

Sized deallocation is a C++14 feature and it was disabled in clang due to potential ABI breaking (https://reviews.llvm.org/D8467). There was guys trying to enable it by default 2 years ago (https://reviews.llvm.org/D112921) but the work suspended later.

@llvmbot
Copy link
Member

llvmbot commented Jan 16, 2023

@llvm/issue-subscribers-c-14

@EugeneZelenko EugeneZelenko added the clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' label Jan 16, 2023
@llvmbot
Copy link
Member

llvmbot commented Jan 16, 2023

@llvm/issue-subscribers-clang-driver

@Romain-Geissler-1A
Copy link
Member

Hi @wangpc-pp,

Do you have any status on enabling this by default which you last tried this summer (https://reviews.llvm.org/D112921) ?

@shafik
Copy link
Collaborator

shafik commented Mar 3, 2024

This feels like a duplicate of: #56505

We should try and keep one main bug and updates and queries should go to that.

@wangpc-pp
Copy link
Contributor

Hi @wangpc-pp,

Do you have any status on enabling this by default which you last tried this summer (https://reviews.llvm.org/D112921) ?

There were some buildbot failures (Windows, AMDGPU) and I don't have such environments, so I suspended the progress.
I'm glad to have another try, but I need some help to fix these failures.

wangpc-pp added a commit that referenced this issue Apr 26, 2024
Since C++14 has been released for about nine years and most standard
libraries have implemented sized deallocation functions, it's time to
make this feature default again.

This is another try of https://reviews.llvm.org/D112921.

Fixes #60061
@vitalybuka
Copy link
Collaborator

Reverted with #90299

@vitalybuka vitalybuka reopened this Apr 27, 2024
wangpc-pp added a commit to wangpc-pp/llvm-project that referenced this issue Apr 28, 2024
Since C++14 has been released for about nine years and most standard
libraries have implemented sized deallocation functions, it's time to
make this feature default again.

This is another try of https://reviews.llvm.org/D112921.

The original commit cf5a8b4 was reverted by 2e5035a due to some
failures (see llvm#83774).

Fixes llvm#60061
wangpc-pp added a commit to wangpc-pp/llvm-project that referenced this issue May 22, 2024
Since C++14 has been released for about nine years and most standard
libraries have implemented sized deallocation functions, it's time to
make this feature default again.

This is another try of https://reviews.llvm.org/D112921.

The original commit cf5a8b4 was reverted by 2e5035a due to some
failures (see llvm#83774).

Fixes llvm#60061
wangpc-pp added a commit that referenced this issue May 22, 2024
#90373)

Since C++14 has been released for about nine years and most standard
libraries have implemented sized deallocation functions, it's time to
make this feature default again.

This is another try of https://reviews.llvm.org/D112921.

The original commit cf5a8b4 was reverted by 2e5035a due to some
failures (see #83774).

Fixes #60061
vitalybuka pushed a commit that referenced this issue Jun 12, 2024
#90373)

Since C++14 has been released for about nine years and most standard
libraries have implemented sized deallocation functions, it's time to
make this feature default again.

This is another try of https://reviews.llvm.org/D112921.

The original commit cf5a8b4 was reverted by 2e5035a due to some
failures (see #83774).

Fixes #60061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++14 clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl'
Projects
None yet
7 participants