Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change library SONAMEs to include minor version #76273

Closed
jyknight opened this issue Dec 22, 2023 · 0 comments · Fixed by #79376
Closed

Change library SONAMEs to include minor version #76273

jyknight opened this issue Dec 22, 2023 · 0 comments · Fixed by #79376
Assignees
@tstellar
Labels
cmake Build system in general and CMake in particular
Milestone
LLVM 18.X Release

Comments

@jyknight
Copy link
Member

As suggested in #75743 and https://discourse.llvm.org/t/rfc-name-the-first-release-from-a-branch-n-1-0-instead-of-n-0-0/75384 there is a desire to switch from just the major version (e.g. "18") to instead use major+minor (e.g. "18.0" or "18.1").
@jyknight jyknight added this to the LLVM 18.0.X Release milestone Dec 22, 2023
@EugeneZelenko EugeneZelenko added cmake Build system in general and CMake in particular and removed new issue labels Dec 22, 2023
tstellar added a commit to tstellar/llvm-project that referenced this issue Jan 24, 2024
@tstellar
[cmake] Add minor version to library SONAME
d07c8b8 
We need to do this now that we are bumping the minor release number
when we create the release branch.

This also results in a slight change to the library names for LLVM.  The
main library now has a more convential library name:
'libLLVM.so.$major.$minor'.  The old library name: libLLVM-$major.so
is now a symlink that points to the new library.  However, the
symlink is not present in the build directory.  It is only present
in the install directory.

The library name was changed because it helped to keep the CMake changes
more simple.

Fixes llvm#76273
@tstellar tstellar mentioned this issue Jan 24, 2024
Merged
tstellar added a commit that referenced this issue Feb 20, 2024
@tstellar
[cmake] Add minor version to library SONAME (#79376)
91a3846 
We need to do this now that we are bumping the minor release number when
we create the release branch.

This also results in a slight change to the library names for LLVM. The
main library now has a more convential library name:
'libLLVM.so.$major.$minor'. The old library name: libLLVM-$major.so is
now a symlink that points to the new library. However, the symlink is
not present in the build directory. It is only present in the install
directory.

The library name was changed because it helped to keep the CMake changes
more simple.

Fixes #76273
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Feb 20, 2024
@tstellar @llvmbot
[cmake] Add minor version to library SONAME (llvm#79376)
4f49c05 
We need to do this now that we are bumping the minor release number when
we create the release branch.

This also results in a slight change to the library names for LLVM. The
main library now has a more convential library name:
'libLLVM.so.$major.$minor'. The old library name: libLLVM-$major.so is
now a symlink that points to the new library. However, the symlink is
not present in the build directory. It is only present in the install
directory.

The library name was changed because it helped to keep the CMake changes
more simple.

Fixes llvm#76273

(cherry picked from commit 91a3846)
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Feb 21, 2024
@tstellar
[cmake] Add minor version to library SONAME (llvm#79376)
1d4de75 
We need to do this now that we are bumping the minor release number when
we create the release branch.

This also results in a slight change to the library names for LLVM. The
main library now has a more convential library name:
'libLLVM.so.$major.$minor'. The old library name: libLLVM-$major.so is
now a symlink that points to the new library. However, the symlink is
not present in the build directory. It is only present in the install
directory.

The library name was changed because it helped to keep the CMake changes
more simple.

Fixes llvm#76273

(cherry picked from commit 91a3846)
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Feb 21, 2024
@tstellar
[cmake] Add minor version to library SONAME (llvm#79376)
235306b 
We need to do this now that we are bumping the minor release number when
we create the release branch.

This also results in a slight change to the library names for LLVM. The
main library now has a more convential library name:
'libLLVM.so.$major.$minor'. The old library name: libLLVM-$major.so is
now a symlink that points to the new library. However, the symlink is
not present in the build directory. It is only present in the install
directory.

The library name was changed because it helped to keep the CMake changes
more simple.

Fixes llvm#76273

(cherry picked from commit 91a3846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tstellar tstellar

Labels
cmake Build system in general and CMake in particular
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 18.X Release
Development

Successfully merging a pull request may close this issue.

[cmake] Add minor version to library SONAME tstellar/llvm-project
3 participants
@tstellar @jyknight @EugeneZelenko