TLS with large code model on x86_64-apple-darwin asserts

[nikic]

target triple = "x86_64-apple-macosx10.12.0"

@g = external thread_local global i8

define ptr @test() {
  ret ptr @g
}

!llvm.module.flags = !{!0}

!0 = !{i32 1, !"Code Model", i32 4}

Results in:

llc: /home/npopov/repos/llvm-project/llvm/lib/Target/X86/X86ISelLowering.cpp:35071: MachineBasicBlock *llvm::X86TargetLowering::EmitLoweredTLSCall(MachineInstr &, MachineBasicBlock *) const: Assertion `MI.getOperand(3).isGlobal() && "This should be a global"' failed.

[llvmbot]

@llvm/issue-subscribers-backend-x86

Author: Nikita Popov (nikic)

```llvm target triple = "x86_64-apple-macosx10.12.0"

@g = external thread_local global i8

define ptr @test() {
ret ptr @g
}

!llvm.module.flags = !{!0}

!0 = !{i32 1, !"Code Model", i32 4}

Results in:

llc: /home/npopov/repos/llvm-project/llvm/lib/Target/X86/X86ISelLowering.cpp:35071: MachineBasicBlock *llvm::X86TargetLowering::EmitLoweredTLSCall(MachineInstr &, MachineBasicBlock *) const: Assertion `MI.getOperand(3).isGlobal() && "This should be a global"' failed.

</details>

[nikic]

Without large code model:

# *** IR Dump After Argument Stack Rebase (x86argumentstackrebase) ***:
# Machine code for function test: IsSSA, TracksLiveness

bb.0 (%ir-block.0):
  ADJCALLSTACKDOWN64 0, 0, 0, implicit-def dead $rsp, implicit-def dead $eflags, implicit-def dead $ssp, implicit $rsp, implicit $ssp
  TLSCall_64 $rip, 1, $noreg, target-flags(x86-tlvp) @g, $noreg, implicit-def $rax, implicit-def dead $eflags, implicit-def dead $df, implicit $rsp, implicit $ssp
  ADJCALLSTACKUP64 0, 0, implicit-def dead $rsp, implicit-def dead $eflags, implicit-def dead $ssp, implicit $rsp, implicit $ssp
  %0:gr64 = COPY $rax
  $rax = COPY %0:gr64
  RET 0, $rax

With large code model:

# *** IR Dump After Argument Stack Rebase (x86argumentstackrebase) ***:
# Machine code for function test: IsSSA, TracksLiveness

bb.0 (%ir-block.0):
  ADJCALLSTACKDOWN64 0, 0, 0, implicit-def dead $rsp, implicit-def dead $eflags, implicit-def dead $ssp, implicit $rsp, implicit $ssp
  %0:gr64 = MOV64ri32 target-flags(x86-tlvp) @g
  TLSCall_64 killed %0:gr64, 1, $noreg, 0, $noreg, implicit-def $rax, implicit-def dead $eflags, implicit-def dead $df, implicit $rsp, implicit $ssp
  ADJCALLSTACKUP64 0, 0, implicit-def dead $rsp, implicit-def dead $eflags, implicit-def dead $ssp, implicit $rsp, implicit $ssp
  %1:gr64 = COPY $rax
  $rax = COPY %1:gr64
  RET 0, $rax

[nikic]

Bisects to c04a05d @aeubanks

[aeubanks]

taking a look

[nikic]

/cherry-pick 5a83bcc

[llvmbot]

/pull-request #81126

[nikic]

@EugeneZelenko Backports are tracked on PRs now. The backport issue is closed when the PR is created.

[EugeneZelenko]

@nikic: Shouldn't issue be reopened when starting backport? It was not a case here.