Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mach-O check for improperly nested .cfi_* regions doesn't take .alt_entry into account #82261

Closed
Amanieu opened this issue Feb 19, 2024 · 0 comments · Fixed by #82268
Closed

Mach-O check for improperly nested .cfi_* regions doesn't take .alt_entry into account #82261

Amanieu opened this issue Feb 19, 2024 · 0 comments · Fixed by #82268
Labels
llvm:asmparser mc Machine (object) code

Comments

@Amanieu
Copy link
Contributor

Amanieu commented Feb 19, 2024

This issue was hit in Amanieu/corosensei#23 where we have code that looks like this:

.globl _stack_init_trampoline
.private_extern _stack_init_trampoline
_stack_init_trampoline:
.cfi_startproc
[...]
.alt_entry _stack_init_trampoline_return
.globl _stack_init_trampoline_return
.private_extern _stack_init_trampoline_return
_stack_init_trampoline_return:
[...]
.cfi_endproc

This currently produces the following error due to https://reviews.llvm.org/D155245:

error: non-private labels cannot appear between .cfi_startproc / .cfi_endproc pairs

However I think (I am not an expert in Mach-O) that this should be valid since the inner label is properly marked with .alt_entry.

cc @jroelofs
@Amanieu Amanieu mentioned this issue Feb 19, 2024
Closed
@EugeneZelenko EugeneZelenko added llvm:asmparser mc Machine (object) code and removed new issue labels Feb 19, 2024
@jroelofs jroelofs mentioned this issue Feb 19, 2024
Merged
jroelofs added a commit to jroelofs/llvm-project that referenced this issue Feb 19, 2024
@jroelofs
Allow .alt_entry symbols to pass the .cfi nesting check
b695bdf 
Fixes: llvm#82261
@sug0 sug0 mentioned this issue Feb 28, 2024
Merged
2 tasks
jroelofs added a commit that referenced this issue Feb 28, 2024
@jroelofs
Allow .alt_entry symbols to pass the .cfi nesting check (#82268)
5b91647 
A symbol with an `N_ALT_ENTRY` attribute may be defined in the middle of
a subsection, so it is reasonable to opt them out of the
`.cfi_{start,end}proc` nesting check.

Fixes: #82261
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Feb 28, 2024
@jroelofs @llvmbot
Allow .alt_entry symbols to pass the .cfi nesting check (llvm#82268)
faed9cb 
A symbol with an `N_ALT_ENTRY` attribute may be defined in the middle of
a subsection, so it is reasonable to opt them out of the
`.cfi_{start,end}proc` nesting check.

Fixes: llvm#82261
(cherry picked from commit 5b91647)
@eigmax eigmax mentioned this issue Feb 28, 2024
Closed
ForsakenHarmony pushed a commit to ForsakenHarmony/llvm-project that referenced this issue Feb 29, 2024
@jroelofs @ForsakenHarmony
Allow .alt_entry symbols to pass the .cfi nesting check (llvm#82268)
6d786a0 
A symbol with an `N_ALT_ENTRY` attribute may be defined in the middle of
a subsection, so it is reasonable to opt them out of the
`.cfi_{start,end}proc` nesting check.

Fixes: llvm#82261
(cherry picked from commit 5b91647)
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Mar 11, 2024
@jroelofs @tstellar
Allow .alt_entry symbols to pass the .cfi nesting check (llvm#82268)
267d9b1 
A symbol with an `N_ALT_ENTRY` attribute may be defined in the middle of
a subsection, so it is reasonable to opt them out of the
`.cfi_{start,end}proc` nesting check.

Fixes: llvm#82261
(cherry picked from commit 5b91647)
@filipnavara filipnavara mentioned this issue Jun 28, 2024
Closed
mylai-mtk pushed a commit to mylai-mtk/llvm-project that referenced this issue Jul 12, 2024
@jroelofs @mylai-mtk
Allow .alt_entry symbols to pass the .cfi nesting check (llvm#82268)
2223554 
A symbol with an `N_ALT_ENTRY` attribute may be defined in the middle of
a subsection, so it is reasonable to opt them out of the
`.cfi_{start,end}proc` nesting check.

Fixes: llvm#82261
This was referenced Aug 7, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
llvm:asmparser mc Machine (object) code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow .alt_entry symbols to pass the .cfi nesting check jroelofs/llvm-project
2 participants
@Amanieu @EugeneZelenko