Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc][math] Entry points and tests needed for some already-implemented math functions #84689

Closed
Flandini opened this issue Mar 10, 2024 · 0 comments · Fixed by #88443
Closed

[libc][math] Entry points and tests needed for some already-implemented math functions #84689

Flandini opened this issue Mar 10, 2024 · 0 comments · Fixed by #88443
Assignees
@Flandini
Labels
libc

Comments

@Flandini
Copy link
Contributor

From discussion with @lntue, the functions nextafterf128, nexttowardf128, nearbyintf128, and scalbnf128, and nanf128 need entry points and tests added. nanf128 will also need some updates to strtonan to make it work for 128-bit.

I plan to work on these.
@github-actions github-actions bot added the libc label Mar 10, 2024
This was referenced Mar 12, 2024
Merged
Merged
lntue pushed a commit that referenced this issue Mar 15, 2024
[libc][math][c23] adds nanf128 (#85201)
b43965a 
Continuing #84689, this one required more changes than the others, so I
am making it a separate PR.

Extends some stuff in `str_to_float.h`, `str_to_integer.h` to work on
types wider than `unsigned long long` and `uint64_t`.

cc @lntue for review.
@Flandini Flandini mentioned this issue Apr 11, 2024
Merged
lntue pushed a commit that referenced this issue Apr 29, 2024
@Flandini
[libc][math] Adds entrypoint and tests for nearbyintf128,scalbnf128 (#…
5e9937d 
…88443)

Closes #84689.

Adding @lntue for review.

I was curious about the implementation of
`round_using_current_rounding_mode` used for the `nearbyint` functions.
It has one of the rounding modes as unreachable
([here](https://github.com/llvm/llvm-project/blob/main/libc/src/__support/FPUtil/NearestIntegerOperations.h#L243)),
and I was wondering if this was okay for the `nearbyint` functions.

---------

Co-authored-by: Michael Flanders <mkf727@cs.washington.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Flandini Flandini

Labels
libc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[libc][math] Adds entrypoint and tests for nearbyintf128,scalbnf128 Flandini/llvm-project
1 participant
@Flandini