[ctx_prof] test tool: generate ctxprof bistream from json #100379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a tool to simplify testing. It generates a valid contextual profile file from a json representation. The tool is authored to allow for future evolution, e.g. if we want to support profile merging or other tasks, not necessarily scoped to testing.
| ; EMPTY-NEXT: <Version op0=1/> | ||
| ; EMPTY-NEXT: </Metadata> | ||
|
|
||
| ; Note that uin64_t are printed as signed values by llvm-bcanalyzer |
| } | ||
| return 0; | ||
| } | ||
| return 1; |
There was a problem hiding this comment.
Probably want to emit an error if it isn't FromJSON
There was a problem hiding this comment.
the flag mechanism takes care of that, added a test though.
There was a problem hiding this comment.
Probably this should be llvm_unreachable then, or have an assert?
| [ | ||
| { | ||
| "Guid": 2000, | ||
| "Counters": [4, 5] |
There was a problem hiding this comment.
I don't see these counter values in the tested output
There was a problem hiding this comment.
I only tested the values for a context, switching to testing the whole output.
| }, | ||
| { | ||
| "Guid": 18446744073709551612, | ||
| "Counters": [5, 9, 10] |
There was a problem hiding this comment.
I don't see these counter values in the tested output
| "Guid": 18446744073709551613, | ||
| "Counters": [6, 7, 8] | ||
| } | ||
| ], |
There was a problem hiding this comment.
Nit, can you align the matching brackets?
There was a problem hiding this comment.
fixed - the reference file is indented.
There was a problem hiding this comment.
Maybe it is github that is making the spacing look off then. Because the end bracket here on line 16 looks to my eyes unaligned with the corresponding open bracket on line 7?
There was a problem hiding this comment.
oh you meant the json not the xml output. sorry. Misread.
There was a problem hiding this comment.
used a formatter this time.
teresajohnson
approved these changes
Jul 25, 2024
| ; Also we have no callee/context at index 0, 2 callsites for index 1, and one for | ||
| ; index 2. | ||
| ; RUN: llvm-bcanalyzer --dump %t/valid.bitstream | head -27 > %t.valid.in | ||
| ; RUN: diff %S/Inputs/valid.expected %t.valid.in |
There was a problem hiding this comment.
Prefer the expected to be inlined here like it was earlier, which will be easier to analyze (and give more meaningful error output) on a mismatch.
| "Guid": 18446744073709551613, | ||
| "Counters": [6, 7, 8] | ||
| } | ||
| ], |
There was a problem hiding this comment.
Maybe it is github that is making the spacing look off then. Because the end bracket here on line 16 looks to my eyes unaligned with the corresponding open bracket on line 7?
| } | ||
| return 0; | ||
| } | ||
| return 1; |
There was a problem hiding this comment.
Probably this should be llvm_unreachable then, or have an assert?
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/2313 Here is the relevant piece of the build log for the reference: |
mtrofin
added a commit
to mtrofin/llvm-project
that referenced
this pull request
Jul 25, 2024
Follow up from PR llvm#100379, this is to avoid output formatting differences.
mtrofin
added a commit
that referenced
this pull request
Jul 25, 2024
Follow up from PR #100379, this is to avoid output formatting differences.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/155/builds/979 Here is the relevant piece of the build log for the reference: |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/1363 Here is the relevant piece of the build log for the reference: |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/193/builds/1343 Here is the relevant piece of the build log for the reference: |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/54/builds/1002 Here is the relevant piece of the build log for the reference: |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/35/builds/1357 Here is the relevant piece of the build log for the reference: |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/145/builds/865 Here is the relevant piece of the build log for the reference: |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/161/builds/882 Here is the relevant piece of the build log for the reference: |
nico
reviewed
Jul 26, 2024
|
|
||
| static cl::SubCommand FromJSON("fromJSON", "Convert from json"); | ||
|
|
||
| static cl::opt<std::string> InputFilename( |
There was a problem hiding this comment.
As mentioned in #89884 (comment) , cl:: is incompatible with GENERATE_DRIVER. Either remove GENERATE_DRIVER, or move this to Opt.
There was a problem hiding this comment.
Ack, I'll take care of of it. Thanks.
mtrofin
added a commit
to mtrofin/llvm-project
that referenced
this pull request
Jul 26, 2024
Follow-up from PR llvm#100379 (llvm#100379 (comment))
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/3505 Here is the relevant piece of the build log for the reference: |
milkice233
pushed a commit
to fedora-riscv/llvm
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tool to simplify testing. It generates a valid contextual profile file from a json representation.
The tool is authored to allow for future evolution, e.g. if we want to support profile merging or other tasks, not necessarily scoped to testing.
Issue #89287