Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc][newhdrgen] Remove shebangs in files other than yaml_to_classes.py #101816

Merged
merged 3 commits into from
Aug 4, 2024

Conversation

overmighty
Copy link
Member

@overmighty overmighty commented Aug 3, 2024

None of the Python files were committed with the executable bit set, and
only yaml_to_classes.py was intended to be executed.

Also sets the executable bit on yaml_to_classes.py and changes the
shebang to run python3 instead of python.

None of the Python files were committed with the executable bit set, and
it seems that only yaml_to_classes.py is intended to be executed.
@llvmbot
Copy link
Member

llvmbot commented Aug 3, 2024

@llvm/pr-subscribers-libc

Author: OverMighty (overmighty)

Changes

None of the Python files were committed with the executable bit set, and
it seems that only yaml_to_classes.py is intended to be executed.


Full diff: https://github.com/llvm/llvm-project/pull/101816.diff

8 Files Affected:

  • (modified) libc/newhdrgen/class_implementation/classes/enumeration.py (-2)
  • (modified) libc/newhdrgen/class_implementation/classes/function.py (-2)
  • (modified) libc/newhdrgen/class_implementation/classes/macro.py (-2)
  • (modified) libc/newhdrgen/class_implementation/classes/object.py (-2)
  • (modified) libc/newhdrgen/class_implementation/classes/type.py (-2)
  • (modified) libc/newhdrgen/gpu_headers.py (-2)
  • (modified) libc/newhdrgen/header.py (-2)
  • (modified) libc/newhdrgen/yaml_to_classes.py (-2)
diff --git a/libc/newhdrgen/class_implementation/classes/enumeration.py b/libc/newhdrgen/class_implementation/classes/enumeration.py
index a01fa74210101..b9848c04ee632 100644
--- a/libc/newhdrgen/class_implementation/classes/enumeration.py
+++ b/libc/newhdrgen/class_implementation/classes/enumeration.py
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-#
 # ====-- Enumeration class for libc function headers ----------*- python -*--==#
 #
 # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
diff --git a/libc/newhdrgen/class_implementation/classes/function.py b/libc/newhdrgen/class_implementation/classes/function.py
index 845ef1aebf54b..d97df7f8a50ec 100644
--- a/libc/newhdrgen/class_implementation/classes/function.py
+++ b/libc/newhdrgen/class_implementation/classes/function.py
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-#
 # ====-- Function class for libc function headers -------------*- python -*--==#
 #
 # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
diff --git a/libc/newhdrgen/class_implementation/classes/macro.py b/libc/newhdrgen/class_implementation/classes/macro.py
index bf17ae6b6c5ab..9a712f2a1c743 100644
--- a/libc/newhdrgen/class_implementation/classes/macro.py
+++ b/libc/newhdrgen/class_implementation/classes/macro.py
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-#
 # ====-- Macro class for libc function headers ----------------*- python -*--==#
 #
 # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
diff --git a/libc/newhdrgen/class_implementation/classes/object.py b/libc/newhdrgen/class_implementation/classes/object.py
index 02f30cba1c48c..f5214452f0349 100644
--- a/libc/newhdrgen/class_implementation/classes/object.py
+++ b/libc/newhdrgen/class_implementation/classes/object.py
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-#
 # ====-- Object class for libc function headers ---------------*- python -*--==#
 #
 # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
diff --git a/libc/newhdrgen/class_implementation/classes/type.py b/libc/newhdrgen/class_implementation/classes/type.py
index 8e4a8f3cc9c58..4ebf8034a4543 100644
--- a/libc/newhdrgen/class_implementation/classes/type.py
+++ b/libc/newhdrgen/class_implementation/classes/type.py
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-#
 # ====-- Type class for libc function headers -----------------*- python -*--==#
 #
 # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
diff --git a/libc/newhdrgen/gpu_headers.py b/libc/newhdrgen/gpu_headers.py
index d123e4af2de65..b26b3a88557b4 100644
--- a/libc/newhdrgen/gpu_headers.py
+++ b/libc/newhdrgen/gpu_headers.py
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-#
 # ===- GPU HeaderFile Class for --export-decls version --------*- python -*--==#
 #
 # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
diff --git a/libc/newhdrgen/header.py b/libc/newhdrgen/header.py
index 7ec2dee596f8c..df8ce613bd0f9 100644
--- a/libc/newhdrgen/header.py
+++ b/libc/newhdrgen/header.py
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-#
 # ====- HeaderFile Class for libc function headers  -----------*- python -*--==#
 #
 # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
diff --git a/libc/newhdrgen/yaml_to_classes.py b/libc/newhdrgen/yaml_to_classes.py
index a9d0e6424eb2c..2a0d2ffac482e 100644
--- a/libc/newhdrgen/yaml_to_classes.py
+++ b/libc/newhdrgen/yaml_to_classes.py
@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-#
 # ===- Generate headers for libc functions  -------------------*- python -*--==#
 #
 # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.

@overmighty overmighty changed the title [libc][newhdrgen] Remove shebangs from Python files [libc][newhdrgen] Remove shebangs from Python files other than yaml_to_classes.py Aug 3, 2024
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@overmighty overmighty changed the title [libc][newhdrgen] Remove shebangs from Python files other than yaml_to_classes.py [libc][newhdrgen] Remove shebangs in files other than yaml_to_classes.py Aug 3, 2024
Copy link
Contributor

@aaryanshukla aaryanshukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchrodingerZhu SchrodingerZhu merged commit f2f410c into llvm:main Aug 4, 2024
6 checks passed
banach-space pushed a commit to banach-space/llvm-project that referenced this pull request Aug 7, 2024
….py (llvm#101816)

None of the Python files were committed with the executable bit set, and
only yaml_to_classes.py was intended to be executed.

Also sets the executable bit on yaml_to_classes.py and changes the
shebang to run python3 instead of python.
kstoimenov pushed a commit to kstoimenov/llvm-project that referenced this pull request Aug 15, 2024
….py (llvm#101816)

None of the Python files were committed with the executable bit set, and
only yaml_to_classes.py was intended to be executed.

Also sets the executable bit on yaml_to_classes.py and changes the
shebang to run python3 instead of python.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants